Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5007)

Unified Diff: chrome/browser/ui/android/navigation_popup.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/navigation_popup.cc
diff --git a/chrome/browser/ui/android/navigation_popup.cc b/chrome/browser/ui/android/navigation_popup.cc
index 53129a227e54f5d79cf8685fd85a95ac26cb5769..3ddf087bec212c2db5b04ad57eb3c1ade2bd551c 100644
--- a/chrome/browser/ui/android/navigation_popup.cc
+++ b/chrome/browser/ui/android/navigation_popup.cc
@@ -80,8 +80,8 @@ void NavigationPopup::OnFaviconDataAvailable(
gfx::ConvertToJavaBitmap(image.ToSkBitmap()).obj());
}
-static jstring GetHistoryUrl(JNIEnv* env, jclass clazz) {
- return ConvertUTF8ToJavaString(env, chrome::kChromeUIHistoryURL).Release();
+static ScopedJavaLocalRef<jstring> GetHistoryUrl(JNIEnv* env, jclass clazz) {
+ return ConvertUTF8ToJavaString(env, chrome::kChromeUIHistoryURL);
}
static jlong Init(JNIEnv* env, jobject obj) {

Powered by Google App Engine
This is Rietveld 408576698