chrome/browser/android/chrome_application.cc - Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_application.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add some newlines for readability Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/library_loader/library_loader_hooks.cc ('k') | chrome/browser/android/download/chrome_download_delegate.cc » ('j') | chrome/browser/signin/oauth2_token_service_delegate_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/chrome_application.cc

diff --git a/chrome/browser/android/chrome_application.cc b/chrome/browser/android/chrome_application.cc

index afb12f6250ef932790067361eb53094328bc94c8..a5661ef46c6021c986c4eafa596c9c87e6ab9107 100644

--- a/chrome/browser/android/chrome_application.cc

+++ b/chrome/browser/android/chrome_application.cc

@@ -81,8 +81,9 @@ void ChangeAppStatusOnIOThread(SafeBrowsingService* sb_service,

} // namespace

-static jstring GetBrowserUserAgent(JNIEnv* env, jclass clazz) {

- return ConvertUTF8ToJavaString(env, GetUserAgent()).Release();

+static ScopedJavaLocalRef<jstring> GetBrowserUserAgent(JNIEnv* env,

+ jclass clazz) {

+ return ConvertUTF8ToJavaString(env, GetUserAgent());

}

static void FlushPersistentData(JNIEnv* env, jclass obj) {