Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5259)

Unified Diff: base/android/library_loader/library_loader_hooks.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/library_loader/library_loader_hooks.cc
diff --git a/base/android/library_loader/library_loader_hooks.cc b/base/android/library_loader/library_loader_hooks.cc
index 2ba78883471c15d80c78e5a6d83a878cc76b98c0..18eb7b949f7943ba6addddc3c8747b9183086797 100644
--- a/base/android/library_loader/library_loader_hooks.cc
+++ b/base/android/library_loader/library_loader_hooks.cc
@@ -152,8 +152,8 @@ void SetVersionNumber(const char* version_number) {
g_library_version_number = strdup(version_number);
}
-jstring GetVersionNumber(JNIEnv* env, jobject jcaller) {
- return ConvertUTF8ToJavaString(env, g_library_version_number).Release();
+ScopedJavaLocalRef<jstring> GetVersionNumber(JNIEnv* env, jobject jcaller) {
+ return ConvertUTF8ToJavaString(env, g_library_version_number);
}
LibraryProcessType GetLibraryProcessType(JNIEnv* env) {

Powered by Google App Engine
This is Rietveld 408576698