Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: android_webview/native/cookie_manager.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/cookie_manager.cc
diff --git a/android_webview/native/cookie_manager.cc b/android_webview/native/cookie_manager.cc
index b7243bd8544c54b13cf2fa3fb309a9942c3180d2..130e76c853098d1085ec5100c31d8f5f6ec74dd3 100644
--- a/android_webview/native/cookie_manager.cc
+++ b/android_webview/native/cookie_manager.cc
@@ -542,12 +542,13 @@ static void SetCookieSync(JNIEnv* env,
CookieManager::GetInstance()->SetCookieSync(host, cookie_value);
}
-static jstring GetCookie(JNIEnv* env, jobject obj, jstring url) {
+static ScopedJavaLocalRef<jstring> GetCookie(JNIEnv* env,
+ jobject obj,
+ jstring url) {
GURL host(ConvertJavaStringToUTF16(env, url));
return base::android::ConvertUTF8ToJavaString(
- env,
- CookieManager::GetInstance()->GetCookie(host)).Release();
+ env, CookieManager::GetInstance()->GetCookie(host));
}
static void RemoveSessionCookies(JNIEnv* env,

Powered by Google App Engine
This is Rietveld 408576698