Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: android_webview/native/aw_settings.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/aw_settings.cc
diff --git a/android_webview/native/aw_settings.cc b/android_webview/native/aw_settings.cc
index c0674f511b00f3369a5f0a27772abafbff89382d..a5ae993bc71502b1c1baba606e3a3b09c0f2a18d 100644
--- a/android_webview/native/aw_settings.cc
+++ b/android_webview/native/aw_settings.cc
@@ -429,8 +429,9 @@ static jlong Init(JNIEnv* env,
return reinterpret_cast<intptr_t>(settings);
}
-static jstring GetDefaultUserAgent(JNIEnv* env, jclass clazz) {
- return base::android::ConvertUTF8ToJavaString(env, GetUserAgent()).Release();
+static ScopedJavaLocalRef<jstring> GetDefaultUserAgent(JNIEnv* env,
+ jclass clazz) {
+ return base::android::ConvertUTF8ToJavaString(env, GetUserAgent());
}
bool RegisterAwSettings(JNIEnv* env) {

Powered by Google App Engine
This is Rietveld 408576698