Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2154)

Unified Diff: chrome/browser/invalidation/invalidation_service_factory_android.h

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nontrivial cases Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/invalidation/invalidation_service_factory_android.h
diff --git a/chrome/browser/invalidation/invalidation_service_factory_android.h b/chrome/browser/invalidation/invalidation_service_factory_android.h
index c4edb3aabc1531e34016a09c93e6cf21469dade7..c0da6985393023b98235f4057d2217761d6171a1 100644
--- a/chrome/browser/invalidation/invalidation_service_factory_android.h
+++ b/chrome/browser/invalidation/invalidation_service_factory_android.h
@@ -1,4 +1,4 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+#// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_INVALIDATION_INVALIDATION_SERVICE_FACTORY_ANDROID_H_
#include <jni.h>
+#include "base/android/scoped_java_ref.h"
namespace invalidation {
@@ -13,8 +14,10 @@ namespace invalidation {
// InvalidationServiceFactory.
class InvalidationServiceFactoryAndroid {
public:
- static jobject GetForProfile(JNIEnv* env, jclass clazz, jobject j_profile);
- static jobject GetForTest(JNIEnv* env, jclass clazz, jobject j_context);
+ static base::android::ScopedJavaLocalRef<jobject>
+ GetForProfile(JNIEnv* env, jclass clazz, jobject j_profile);
+ static base::android::ScopedJavaLocalRef<jobject>
+ GetForTest(JNIEnv* env, jclass clazz, jobject j_context);
static bool Register(JNIEnv* env);
};

Powered by Google App Engine
This is Rietveld 408576698