chrome/browser/dom_distiller/dom_distiller_service_factory_android.h - Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/dom_distiller/dom_distiller_service_factory_android.h

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nontrivial cases Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/android/personal_data_manager_android.cc ('k') | chrome/browser/dom_distiller/dom_distiller_service_factory_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/dom_distiller/dom_distiller_service_factory_android.h

diff --git a/chrome/browser/dom_distiller/dom_distiller_service_factory_android.h b/chrome/browser/dom_distiller/dom_distiller_service_factory_android.h

index a44584c4e880eb066a784222ad5ee31d1b9b9f4e..5e8f9a49a3055c844e661f6e64b56a34fe01a5d9 100644

--- a/chrome/browser/dom_distiller/dom_distiller_service_factory_android.h

+++ b/chrome/browser/dom_distiller/dom_distiller_service_factory_android.h

@@ -6,6 +6,7 @@

#define CHROME_BROWSER_DOM_DISTILLER_DOM_DISTILLER_SERVICE_FACTORY_ANDROID_H_

#include <jni.h>

+#include "base/android/scoped_java_ref.h"

namespace dom_distiller {

namespace android {

@@ -14,7 +15,8 @@ namespace android {

// DomDistillerServiceFactory.

class DomDistillerServiceFactoryAndroid {

public:

- static jobject GetForProfile(JNIEnv* env, jclass clazz, jobject j_profile);

+ static base::android::ScopedJavaLocalRef<jobject>

+ GetForProfile(JNIEnv* env, jclass clazz, jobject j_profile);

rmcilroy 2015/08/18 13:26:10 nit - add newline below for clarity

static bool Register(JNIEnv* env);

};