chrome/browser/dom_distiller/dom_distiller_service_factory_android.h - Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/dom_distiller/dom_distiller_service_factory_android.h

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nontrivial cases Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/autofill/android/personal_data_manager_android.cc ('k') | chrome/browser/dom_distiller/dom_distiller_service_factory_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_DOM_DISTILLER_DOM_DISTILLER_SERVICE_FACTORY_ANDROID_H_	5 #ifndef CHROME_BROWSER_DOM_DISTILLER_DOM_DISTILLER_SERVICE_FACTORY_ANDROID_H_

6 #define CHROME_BROWSER_DOM_DISTILLER_DOM_DISTILLER_SERVICE_FACTORY_ANDROID_H_	6 #define CHROME_BROWSER_DOM_DISTILLER_DOM_DISTILLER_SERVICE_FACTORY_ANDROID_H_

7	7

8 #include <jni.h>	8 #include <jni.h>

	9 #include "base/android/scoped_java_ref.h"

9	10

10 namespace dom_distiller {	11 namespace dom_distiller {

11 namespace android {	12 namespace android {

12	13

13 // This class should not be used except from the Java class	14 // This class should not be used except from the Java class

14 // DomDistillerServiceFactory.	15 // DomDistillerServiceFactory.

15 class DomDistillerServiceFactoryAndroid {	16 class DomDistillerServiceFactoryAndroid {

16 public:	17 public:

17 static jobject GetForProfile(JNIEnv* env, jclass clazz, jobject j_profile);	18 static base::android::ScopedJavaLocalRef<jobject>

	19 GetForProfile(JNIEnv* env, jclass clazz, jobject j_profile);
	rmcilroy 2015/08/18 13:26:10 nit - add newline below for clarity nit - add newline below for clarity
18 static bool Register(JNIEnv* env);	20 static bool Register(JNIEnv* env);

19 };	21 };

20	22

21 } // namespace android	23 } // namespace android

22 } // namespace dom_distiller	24 } // namespace dom_distiller

23	25

24 #endif // CHROME_BROWSER_DOM_DISTILLER_DOM_DISTILLER_SERVICE_FACTORY_ANDROID_H_	26 #endif // CHROME_BROWSER_DOM_DISTILLER_DOM_DISTILLER_SERVICE_FACTORY_ANDROID_H_

OLD	NEW