Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3253)

Unified Diff: chrome/browser/android/url_utilities.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nontrivial cases Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/url_utilities.cc
diff --git a/chrome/browser/android/url_utilities.cc b/chrome/browser/android/url_utilities.cc
index e9224f43ccf3fe5d1756079d339f43dfda49d9f4..44c4b35243d2d076afb2dfffd5504458120ae487 100644
--- a/chrome/browser/android/url_utilities.cc
+++ b/chrome/browser/android/url_utilities.cc
@@ -43,22 +43,22 @@ static jboolean SameDomainOrHost(JNIEnv* env,
filter);
}
-static jstring GetDomainAndRegistry(JNIEnv* env,
- jclass clazz,
- jstring url,
- jboolean include_private) {
+static ScopedJavaLocalRef<jstring> GetDomainAndRegistry(
+ JNIEnv* env,
+ jclass clazz,
+ jstring url,
+ jboolean include_private) {
DCHECK(url);
GURL gurl = ConvertJavaStringToGURL(env, url);
if (gurl.is_empty())
- return nullptr;
+ return ScopedJavaLocalRef<jstring>();
net::registry_controlled_domains::PrivateRegistryFilter filter =
GetRegistryFilter(include_private);
- // OK to release, JNI binding.
return base::android::ConvertUTF8ToJavaString(
- env, net::registry_controlled_domains::GetDomainAndRegistry(
- gurl, filter)).Release();
+ env,
+ net::registry_controlled_domains::GetDomainAndRegistry(gurl, filter));
}
static jboolean IsGoogleSearchUrl(JNIEnv* env, jclass clazz, jstring url) {
@@ -75,10 +75,10 @@ static jboolean IsGoogleHomePageUrl(JNIEnv* env, jclass clazz, jstring url) {
return google_util::IsGoogleHomePageUrl(gurl);
}
-static jstring FixupUrl(JNIEnv* env,
- jclass clazz,
- jstring url,
- jstring optional_desired_tld) {
+static ScopedJavaLocalRef<jstring> FixupUrl(JNIEnv* env,
+ jclass clazz,
+ jstring url,
+ jstring optional_desired_tld) {
DCHECK(url);
GURL fixed_url = url_formatter::FixupURL(
base::android::ConvertJavaStringToUTF8(env, url),
@@ -86,9 +86,9 @@ static jstring FixupUrl(JNIEnv* env,
? base::android::ConvertJavaStringToUTF8(env, optional_desired_tld)
: std::string());
- return fixed_url.is_valid() ?
- base::android::ConvertUTF8ToJavaString(env, fixed_url.spec()).Release() :
- nullptr;
+ return fixed_url.is_valid()
+ ? base::android::ConvertUTF8ToJavaString(env, fixed_url.spec())
+ : ScopedJavaLocalRef<jstring>();
}
// Register native methods

Powered by Google App Engine
This is Rietveld 408576698