chrome/browser/android/password_ui_view_android.cc - Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/password_ui_view_android.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nontrivial cases Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/omnibox/autocomplete_controller_android.cc ('k') | chrome/browser/android/preferences/autofill/autofill_profile_bridge.cc » ('j') | chrome/browser/dom_distiller/dom_distiller_service_factory_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/password_ui_view_android.cc

diff --git a/chrome/browser/android/password_ui_view_android.cc b/chrome/browser/android/password_ui_view_android.cc

index 4cbf00b26c96ccf4470d209eace0c031f812cb65..d71d1ed2e4d6b191f6bf9fb0b56a29f47f7f55ed 100644

--- a/chrome/browser/android/password_ui_view_android.cc

+++ b/chrome/browser/android/password_ui_view_android.cc

@@ -110,9 +110,9 @@ void PasswordUIViewAndroid::HandleRemoveSavedPasswordException(

password_manager_presenter_.RemovePasswordException(index);

}

-jstring GetAccountDashboardURL(JNIEnv* env, jclass) {

- return ConvertUTF8ToJavaString(

- env, chrome::kPasswordManagerAccountDashboardURL).Release();

+ScopedJavaLocalRef<jstring> GetAccountDashboardURL(JNIEnv* env, jclass) {

+ return ConvertUTF8ToJavaString(env,

+ chrome::kPasswordManagerAccountDashboardURL);

}

static jboolean ShouldDisplayManageAccountLink(