Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1288063010: Adding nullptr check in CanvasRenderingContext2D::draw (Closed)

Created:
5 years, 4 months ago by Justin Novosad
Modified:
5 years, 4 months ago
Reviewers:
Stephen White
CC:
blink-reviews, dshwang, Rik, Justin Novosad
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Adding nullptr check in CanvasRenderingContext2D::draw BUG=522799 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200919

Patch Set 1 #

Patch Set 2 : build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 895153002 Patch 100001

Messages

Total messages: 14 (7 generated)
Justin Novosad
PTAL
5 years, 4 months ago (2015-08-20 15:40:36 UTC) #2
Stephen White
LGTM
5 years, 4 months ago (2015-08-20 15:41:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288063010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288063010/1
5 years, 4 months ago (2015-08-20 16:03:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288063010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288063010/20001
5 years, 4 months ago (2015-08-20 16:05:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/101716)
5 years, 4 months ago (2015-08-20 16:57:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288063010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288063010/20001
5 years, 4 months ago (2015-08-20 18:28:00 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 18:33:00 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200919

Powered by Google App Engine
This is Rietveld 408576698