Source/modules/canvas2d/CanvasRenderingContext2D.cpp - Issue 1288063010: Adding nullptr check in CanvasRenderingContext2D::draw

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/canvas2d/CanvasRenderingContext2D.cpp

Issue 1288063010: Adding nullptr check in CanvasRenderingContext2D::draw (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: build fix Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/canvas2d/CanvasRenderingContext2D.cpp

diff --git a/Source/modules/canvas2d/CanvasRenderingContext2D.cpp b/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

index 41d48fe8be8d093508a6b6f92642f749708b670b..2834b4e063dc7c9f171f5320aa9c8581b8bd700b 100644

--- a/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

+++ b/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

@@ -885,7 +885,7 @@ bool CanvasRenderingContext2D::draw(const DrawFunc& drawFunc, const ContainsFunc

return false;

SkIRect clipBounds;

- if (!drawingCanvas()->getClipDeviceBounds(&clipBounds))

+ if (!drawingCanvas() || !drawingCanvas()->getClipDeviceBounds(&clipBounds))

return false;

// If gradient size is zero, then paint nothing.

« no previous file with comments | « no previous file | no next file » | no next file with comments »