Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: fpdfsdk/src/javascript/app.cpp

Issue 1287863002: Remove if checks after new. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: nits Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/src/fxedit/fxet_list.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_Wnd.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/src/javascript/app.cpp
diff --git a/fpdfsdk/src/javascript/app.cpp b/fpdfsdk/src/javascript/app.cpp
index 24f00ca262d24f03d99bc5b170f46c4892e2ce01..1b84508fd6ef848f572d0d0af7ff8806a4d34eed 100644
--- a/fpdfsdk/src/javascript/app.cpp
+++ b/fpdfsdk/src/javascript/app.cpp
@@ -298,19 +298,12 @@ FX_BOOL app::alert(IFXJS_Context* cc,
if (swMsg == L"") {
CJS_Array carray(isolate);
if (params[0].ConvertToArray(carray)) {
- int iLenth = carray.GetLength();
+ int iLength = carray.GetLength();
CJS_Value* pValue = new CJS_Value(isolate);
- // if (iLenth == 1)
- // pValue = new
- // CJS_Value(isolate);
- // else if (iLenth > 1)
- // pValue = new
- // CJS_Value[iLenth];
-
- for (int i = 0; i < iLenth; i++) {
+ for (int i = 0; i < iLength; ++i) {
carray.GetElement(i, *pValue);
swMsg += (*pValue).ToCFXWideString();
- if (i < iLenth - 1)
+ if (i < iLength - 1)
swMsg += L", ";
}
« no previous file with comments | « fpdfsdk/src/fxedit/fxet_list.cpp ('k') | fpdfsdk/src/pdfwindow/PWL_Wnd.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698