Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: runtime/vm/atomic_win.h

Issue 1287853005: Compatible atomics: volatile for LoadRelaxed, replace FetchAndAdd with FetchAndDecrement. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Additional comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/atomic_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/atomic_win.h
diff --git a/runtime/vm/atomic_win.h b/runtime/vm/atomic_win.h
index 0c31e592aa6b4d1bee4cb70f00f0df0c2562b8fb..4ef539c3a3f3f639496b4fe2947653b505c95ca8 100644
--- a/runtime/vm/atomic_win.h
+++ b/runtime/vm/atomic_win.h
@@ -28,13 +28,13 @@ inline uintptr_t AtomicOperations::FetchAndIncrement(uintptr_t* p) {
}
-inline intptr_t AtomicOperations::FetchAndAdd(intptr_t* p, intptr_t delta) {
+inline uintptr_t AtomicOperations::FetchAndDecrement(uintptr_t* p) {
#if defined(HOST_ARCH_X64)
- return static_cast<intptr_t>(
- InterlockedAdd64(reinterpret_cast<LONGLONG*>(p), delta)) - delta;
+ return static_cast<uintptr_t>(
+ InterlockedDecrement64(reinterpret_cast<LONGLONG*>(p))) + 1;
#elif defined(HOST_ARCH_IA32)
- return static_cast<intptr_t>(
- InterlockedAdd(reinterpret_cast<LONG*>(p), delta)) - delta;
+ return static_cast<uintptr_t>(
+ InterlockedDecrement(reinterpret_cast<LONG*>(p))) + 1;
#else
#error Unsupported host architecture.
#endif
« no previous file with comments | « runtime/vm/atomic_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698