Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1843)

Unified Diff: runtime/vm/atomic_test.cc

Issue 1287853005: Compatible atomics: volatile for LoadRelaxed, replace FetchAndAdd with FetchAndDecrement. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Additional comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/atomic_macos.h ('k') | runtime/vm/atomic_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/atomic_test.cc
diff --git a/runtime/vm/atomic_test.cc b/runtime/vm/atomic_test.cc
index 35f8b51dcdfae9044ef9e0b688c7c87585254ab4..5e22606047e83c6b6bb253fce715d332352ccabd 100644
--- a/runtime/vm/atomic_test.cc
+++ b/runtime/vm/atomic_test.cc
@@ -18,14 +18,11 @@ UNIT_TEST_CASE(FetchAndIncrement) {
}
-UNIT_TEST_CASE(FetchAndAdd) {
- intptr_t v = 42;
- EXPECT_EQ(42, AtomicOperations::FetchAndAdd(&v, 0));
- EXPECT_EQ(42, v);
- EXPECT_EQ(42, AtomicOperations::FetchAndAdd(&v, 2));
- EXPECT_EQ(44, v);
- EXPECT_EQ(44, AtomicOperations::FetchAndAdd(&v, -2));
- EXPECT_EQ(42, v);
+UNIT_TEST_CASE(FetchAndDecrement) {
+ uintptr_t v = 42;
+ EXPECT_EQ(static_cast<uintptr_t>(42),
+ AtomicOperations::FetchAndDecrement(&v));
+ EXPECT_EQ(static_cast<uintptr_t>(41), v);
}
« no previous file with comments | « runtime/vm/atomic_macos.h ('k') | runtime/vm/atomic_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698