runtime/vm/atomic_macos.h - Issue 1287853005: Compatible atomics: volatile for LoadRelaxed, replace FetchAndAdd with FetchAndDecrement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/atomic_macos.h

Issue 1287853005: Compatible atomics: volatile for LoadRelaxed, replace FetchAndAdd with FetchAndDecrement. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Additional comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/atomic_macos.h

diff --git a/runtime/vm/atomic_macos.h b/runtime/vm/atomic_macos.h

index bc2ed6a17a9eceff5ebc03e76e5f028b9446dc02..b56d2a0abd7bc5ea5e0c6dbaeeb2b345710ce0c2 100644

--- a/runtime/vm/atomic_macos.h

+++ b/runtime/vm/atomic_macos.h

@@ -21,8 +21,8 @@ inline uintptr_t AtomicOperations::FetchAndIncrement(uintptr_t* p) {

}

-inline intptr_t AtomicOperations::FetchAndAdd(intptr_t* p, intptr_t delta) {

- return __sync_fetch_and_add(p, delta);

+inline uintptr_t AtomicOperations::FetchAndDecrement(uintptr_t* p) {

+ return __sync_fetch_and_sub(p, 1);

}

« no previous file with comments | « runtime/vm/atomic_linux.h ('k') | runtime/vm/atomic_test.cc » ('j') | no next file with comments »