Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1287783003: Make ClientHintsPreferences class work like a class. (Closed)

Created:
5 years, 4 months ago by dglazkov
Modified:
5 years, 4 months ago
Reviewers:
Yoav Weiss
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, Nate Chapin, kinuko+watch, rwlbuis, sof, tyoshino+watch_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Make ClientHintsPreferences class work like a class. Instead of pretending it's a struct, let's make it a real class, with functions that help along the commont usage patterns at the callsites. R=yoav@yoav.ws BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -48 lines) Patch
M Source/core/dom/Document.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/fetch/ClientHintsPreferences.h View 2 chunks +11 lines, -19 lines 0 comments Download
M Source/core/fetch/ClientHintsPreferences.cpp View 1 chunk +24 lines, -9 lines 0 comments Download
M Source/core/fetch/ClientHintsPreferencesTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/FetchRequest.h View 1 chunk +13 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/PreloadRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameFetchContextTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/HttpEquiv.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287783003/1
5 years, 4 months ago (2015-08-14 23:55:37 UTC) #2
dglazkov
PTAL. This is mostly just moving code around.
5 years, 4 months ago (2015-08-15 00:08:01 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-15 01:02:32 UTC) #5
Yoav Weiss
On 2015/08/15 01:02:32, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 4 months ago (2015-08-15 05:04:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287783003/1
5 years, 4 months ago (2015-08-15 05:04:32 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 05:09:44 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200598

Powered by Google App Engine
This is Rietveld 408576698