Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1419)

Unified Diff: Source/core/loader/FrameFetchContextTest.cpp

Issue 1287783003: Make ClientHintsPreferences class work like a class. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/FrameFetchContext.cpp ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/FrameFetchContextTest.cpp
diff --git a/Source/core/loader/FrameFetchContextTest.cpp b/Source/core/loader/FrameFetchContextTest.cpp
index 5b89caba3dc07a982678a4515c3fd5af7f5c9317..23d2a8f4a4c4594d3ad2643dd1922b15f5294d2b 100644
--- a/Source/core/loader/FrameFetchContextTest.cpp
+++ b/Source/core/loader/FrameFetchContextTest.cpp
@@ -274,7 +274,7 @@ TEST_F(FrameFetchContextHintsTest, MonitorDPRHints)
expectHeader("http://www.example.com/1.gif", "DPR", false, "");
ClientHintsPreferences preferences;
preferences.setShouldSendDPR(true);
- document->setClientHintsPreferences(preferences);
+ document->clientHintsPreferences().updateFrom(preferences);
expectHeader("http://www.example.com/1.gif", "DPR", true, "1");
dummyPageHolder->page().setDeviceScaleFactor(2.5);
expectHeader("http://www.example.com/1.gif", "DPR", true, "2.5");
@@ -287,7 +287,7 @@ TEST_F(FrameFetchContextHintsTest, MonitorResourceWidthHints)
expectHeader("http://www.example.com/1.gif", "Width", false, "");
ClientHintsPreferences preferences;
preferences.setShouldSendResourceWidth(true);
- document->setClientHintsPreferences(preferences);
+ document->clientHintsPreferences().updateFrom(preferences);
expectHeader("http://www.example.com/1.gif", "Width", true, "500", 500);
expectHeader("http://www.example.com/1.gif", "Width", true, "667", 666.6666);
expectHeader("http://www.example.com/1.gif", "DPR", false, "");
@@ -298,7 +298,7 @@ TEST_F(FrameFetchContextHintsTest, MonitorViewportWidthHints)
expectHeader("http://www.example.com/1.gif", "Viewport-Width", false, "");
ClientHintsPreferences preferences;
preferences.setShouldSendViewportWidth(true);
- document->setClientHintsPreferences(preferences);
+ document->clientHintsPreferences().updateFrom(preferences);
expectHeader("http://www.example.com/1.gif", "Viewport-Width", true, "500");
dummyPageHolder->frameView().setLayoutSizeFixedToFrameSize(false);
dummyPageHolder->frameView().setLayoutSize(IntSize(800, 800));
@@ -317,7 +317,7 @@ TEST_F(FrameFetchContextHintsTest, MonitorAllHints)
preferences.setShouldSendDPR(true);
preferences.setShouldSendResourceWidth(true);
preferences.setShouldSendViewportWidth(true);
- document->setClientHintsPreferences(preferences);
+ document->clientHintsPreferences().updateFrom(preferences);
expectHeader("http://www.example.com/1.gif", "DPR", true, "1");
expectHeader("http://www.example.com/1.gif", "Width", true, "400", 400);
expectHeader("http://www.example.com/1.gif", "Viewport-Width", true, "500");
« no previous file with comments | « Source/core/loader/FrameFetchContext.cpp ('k') | Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698