chrome/browser/resources/settings/checkbox/checkbox.js - Issue 1287713002: [MD settings] merge polymer 1.0.11; hack for settings checkbox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/checkbox/checkbox.js

Issue 1287713002: [MD settings] merge polymer 1.0.11; hack for settings checkbox (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/iron-a11y-keys-behavior-extracted.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/checkbox/checkbox.js

diff --git a/chrome/browser/resources/settings/checkbox/checkbox.js b/chrome/browser/resources/settings/checkbox/checkbox.js

index d4bdeb4fc378da44e7864b61c7b6c070f9f80383..39dd913db5fdd3f4f0b3f17039498286637c5b82 100644

--- a/chrome/browser/resources/settings/checkbox/checkbox.js

+++ b/chrome/browser/resources/settings/checkbox/checkbox.js

@@ -57,6 +57,15 @@ Polymer({

this.$.events.forward(this.$.checkbox, ['change']);

+ /** @override */

+ attached: function() {

+ // HACK(dschuyler): paper-checkbox 1.0.6 will hide the label

+ // if the content is empty.

+ // TODO(dschuyler): rework settings checkbox to use content

+ // rather than spans.

+ this.$.checkbox.$.checkbox.$.checkboxLabel.hidden = false;

+ },

stevenjb 2015/08/13 21:44:38 Is there any reason why this was done here instead

/** @private */

prefValueChanged_: function(prefValue) {

// prefValue is initially undefined when Polymer initializes pref.