Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1287703002: Fix some sign comparison warnings. (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Fix some sign comparison warnings. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1279493003 . (cherry picked from commit b4c2167fff88665089eeab47afa45a9e890060a3) Committed: https://pdfium.googlesource.com/pdfium/+/b9c3197d815295632be4612301ee635e5eb95df1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -43 lines) Patch
M fpdfsdk/src/formfiller/FFL_ListBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 9 chunks +16 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
TBR, clean merge.
5 years, 4 months ago (2015-08-11 21:09:32 UTC) #1
Lei Zhang
Committed patchset #1 (id:1) manually as b9c3197d815295632be4612301ee635e5eb95df1 (presubmit successful).
5 years, 4 months ago (2015-08-11 21:09:38 UTC) #2
Tom Sepez
5 years, 4 months ago (2015-08-11 21:10:04 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698