Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1279493003: Fix some sign comparison warnings. (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -43 lines) Patch
M fpdfsdk/src/formfiller/FFL_ListBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfdoc_embeddertest.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 9 chunks +16 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
5 years, 4 months ago (2015-08-10 07:29:20 UTC) #2
Tom Sepez
lgtm
5 years, 4 months ago (2015-08-11 20:51:17 UTC) #3
Lei Zhang
5 years, 4 months ago (2015-08-11 20:55:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b4c2167fff88665089eeab47afa45a9e890060a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698