Issue 12875005: Add support for IMG's MSAA extension.

Issue 12875005: Add support for IMG's MSAA extension. (Closed)

Created:
7 years, 9 months ago by bsalomon

Modified:
7 years, 9 months ago

Reviewers:
jvanverth1, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add support for IMG's MSAA extension. Committed: https://code.google.com/p/skia/source/detail?r=8241

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -62 lines)			Patch
M	include/gpu/gl/GrGLFunctions.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/gpu/gl/GrGLInterface.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLDefines.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLInterface.cpp	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	1 2	7 chunks	+67 lines, -62 lines	0 comments	Download
M	src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + suggestions https://codereview.chromium.org/12875005/diff/10001/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.chromium.org/12875005/diff/10001/src/gpu/gl/GrGpuGL.cpp#newcode1788 src/gpu/gl/GrGpuGL.cpp:1788: const GrGLIRect& vp = rt->getViewport(); can ...

7 years, 9 months ago (2013-03-19 15:35:35 UTC) #2

bsalomon

Committed patchset #3 manually as r8241 (presubmit successful).

7 years, 9 months ago (2013-03-19 19:06:17 UTC) #3

bsalomon

7 years, 9 months ago (2013-03-19 19:06:42 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/12875005/diff/10001/src/gpu/gl/GrGpuGL.cpp
File src/gpu/gl/GrGpuGL.cpp (right):

https://codereview.chromium.org/12875005/diff/10001/src/gpu/gl/GrGpuGL.cpp#ne...
src/gpu/gl/GrGpuGL.cpp:1788: const GrGLIRect& vp = rt->getViewport();
On 2013/03/19 15:35:35, robertphillips wrote:
> can this be "const GrIRect&"?

No, it's x/y/width/height bottom-left origin.

https://codereview.chromium.org/12875005/diff/10001/src/gpu/gl/GrGpuGL.cpp#ne...
src/gpu/gl/GrGpuGL.cpp:1805: GrAssert(GrGLCaps::kDesktopEXT_MSFBOType ==
On 2013/03/19 15:35:35, robertphillips wrote:
> move up a line?

Done.

Expand Messages | Collapse Messages