Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: Source/bindings/dart/DartService.h

Issue 128733002: Refactor service usage in Dartium (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/1700
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/dart/DartService.h
diff --git a/Source/bindings/dart/DartService.h b/Source/bindings/dart/DartService.h
index 9d342bf5d4f60932ff45e20d7c6ece352c1345c6..611915e97351370c2535b1c840c6ff57a49df831 100644
--- a/Source/bindings/dart/DartService.h
+++ b/Source/bindings/dart/DartService.h
@@ -12,7 +12,6 @@
namespace WebCore {
-class DartServiceInternal;
class Document;
class DartServiceRequest {
@@ -33,32 +32,15 @@ class DartService {
public:
// Returns false if service could not be started.
static bool Start(Document*);
- static bool Stop();
-
// Error message if startup failed.
static const char* GetErrorMessage();
-
- static Dart_Port port();
- static Dart_Port GetRequestPort() { return m_requestPort; }
- static bool IsRunning();
-
- static bool SendIsolateStartupMessage();
- static bool SendIsolateShutdownMessage();
static void MakeServiceRequest(DartServiceRequest*);
- static void VmServiceShutdownCallback(void* callbackData);
+ static bool IsRunning() { return m_isolate != 0; } // NOLINT
siva 2014/01/14 18:57:34 I think we don't compare against 0 in dartium code
Cutch 2014/01/14 21:17:18 Done.
private:
- static Dart_Handle GetSource(const char* name);
- static Dart_Handle LoadScript(const char* name);
- static Dart_Handle LoadSources(Dart_Handle library, const char** names);
- static Dart_Handle LoadSource(Dart_Handle library, const char* name);
- static Dart_Handle LoadResources(Dart_Handle library);
- static Dart_Handle LoadResource(Dart_Handle library, const char* name, const char* prefix);
- static Dart_Handle LibraryTagHandler(Dart_LibraryTag, Dart_Handle library, Dart_Handle url);
+ static Dart_Handle LoadScript();
static Dart_NativeFunction NativeResolver(Dart_Handle name, int numArguments, bool* autoScopeSetup);
static Dart_Isolate m_isolate;
- static Dart_Port m_port;
- static Dart_Port m_requestPort;
static const char* m_errorMsg;
friend class DartServiceInternal;
};

Powered by Google App Engine
This is Rietveld 408576698