Refactor service usage in Dartium

Source/bindings/dart/DartService.h

 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef DartService_h
 #define DartService_h
 
 #include "wtf/text/WTFString.h"
 
 #include <dart_api.h>
 #include <dart_native_api.h>
 
 namespace WebCore {
 
-class DartServiceInternal;
 class Document;
 
 class DartServiceRequest {
 public:
     DartServiceRequest(const String& request);
     virtual ~DartServiceRequest();
 
     // Override this method and it will be called when
     // the response has been received from the VM service.
     virtual void ResponseReady(const char* response) = 0;
 
     const String& GetRequestString() { return m_request; };
 private:
     String m_request;
 };
 
 class DartService {
 public:
     // Returns false if service could not be started.
     static bool Start(Document*);
-    static bool Stop();
-
     // Error message if startup failed.
     static const char* GetErrorMessage();
-
-    static Dart_Port port();
-    static Dart_Port GetRequestPort() { return m_requestPort; }
-    static bool IsRunning();
-
-    static bool SendIsolateStartupMessage();
-    static bool SendIsolateShutdownMessage();
     static void MakeServiceRequest(DartServiceRequest*);
-    static void VmServiceShutdownCallback(void* callbackData);
+    static bool IsRunning() { return m_isolate != 0; }  // NOLINT

[siva, 2014/01/14 18:57:34]

I think we don't compare against 0 in dartium code, instead we just use return
m_isolate here that would avoid the NOLINT comment.

[Cutch, 2014/01/14 21:17:18]

Done.

 
 private:
-    static Dart_Handle GetSource(const char* name);
-    static Dart_Handle LoadScript(const char* name);
-    static Dart_Handle LoadSources(Dart_Handle library, const char** names);
-    static Dart_Handle LoadSource(Dart_Handle library, const char* name);
-    static Dart_Handle LoadResources(Dart_Handle library);
-    static Dart_Handle LoadResource(Dart_Handle library, const char* name, const char* prefix);
-    static Dart_Handle LibraryTagHandler(Dart_LibraryTag, Dart_Handle library, Dart_Handle url);
+    static Dart_Handle LoadScript();
     static Dart_NativeFunction NativeResolver(Dart_Handle name, int numArguments, bool* autoScopeSetup);
     static Dart_Isolate m_isolate;
-    static Dart_Port m_port;
-    static Dart_Port m_requestPort;
     static const char* m_errorMsg;
     friend class DartServiceInternal;
 };
 
 }
 
 #endif // DartService_h