[Fetch] Add a deprecation warning for Request.context

[Fetch] Add a deprecation warning for Request.context

Request.context is removed from the spec:
https://github.com/whatwg/fetch/issues/93
and we will remove it in M-46.

This CL adds a deprecation warning to M-46 a little before Request.context is
actually removed by https://codereview.chromium.org/1292503002/, and
is to be merged into M-45.

BUG=515786
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200553

[hiroshige, 2015-08-13 10:34:38]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-13 10:35:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287273002/1

[hiroshige, 2015-08-13 10:57:16]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-13 10:57:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287273002/20001

[hiroshige, 2015-08-13 10:58:35]

hiroshige@chromium.org changed reviewers:
+ falken@chromium.org

[hiroshige, 2015-08-13 10:58:36]

falken@, could you take a look?

[falken, 2015-08-13 11:37:19]

Thanks for making the warning!

https://codereview.chromium.org/1287273002/diff/20001/Source/modules/fetch/Re...
File Source/modules/fetch/Request.cpp (right):

https://codereview.chromium.org/1287273002/diff/20001/Source/modules/fetch/Re...
Source/modules/fetch/Request.cpp:345:
executionContext()->addConsoleMessage(ConsoleMessage::create(DeprecationMessageSource,
WarningMessageLevel, "Request.context is deprecated and will be removed in
M46."));
Deprecation messages are usually added to UseCounter.cpp:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[hiroshige, 2015-08-13 11:39:10]

https://codereview.chromium.org/1287273002/diff/20001/Source/modules/fetch/Re...
File Source/modules/fetch/Request.cpp (right):

https://codereview.chromium.org/1287273002/diff/20001/Source/modules/fetch/Re...
Source/modules/fetch/Request.cpp:345:
executionContext()->addConsoleMessage(ConsoleMessage::create(DeprecationMessageSource,
WarningMessageLevel, "Request.context is deprecated and will be removed in
M46."));
On 2015/08/13 11:37:19, falken wrote:
> Deprecation messages are usually added to UseCounter.cpp:
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 

Hmm, so we should add a new use counter and corresponding deprecation message,
right?

[falken, 2015-08-13 11:45:11]

https://codereview.chromium.org/1287273002/diff/20001/Source/modules/fetch/Re...
File Source/modules/fetch/Request.cpp (right):

https://codereview.chromium.org/1287273002/diff/20001/Source/modules/fetch/Re...
Source/modules/fetch/Request.cpp:345:
executionContext()->addConsoleMessage(ConsoleMessage::create(DeprecationMessageSource,
WarningMessageLevel, "Request.context is deprecated and will be removed in
M46."));
On 2015/08/13 11:39:10, hiroshige wrote:
> On 2015/08/13 11:37:19, falken wrote:
> > Deprecation messages are usually added to UseCounter.cpp:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> > 
> 
> Hmm, so we should add a new use counter and corresponding deprecation message,
> right?

I think that's the convention, that's what I did for Client.postMessage:
https://codereview.chromium.org/925293002

This also means the author doesn't get spammed with deprecation warnings if they
use the feature multiple times in a page.

[hiroshige, 2015-08-13 12:01:23]

https://codereview.chromium.org/1287273002/diff/20001/Source/modules/fetch/Re...
File Source/modules/fetch/Request.cpp (right):

https://codereview.chromium.org/1287273002/diff/20001/Source/modules/fetch/Re...
Source/modules/fetch/Request.cpp:345:
executionContext()->addConsoleMessage(ConsoleMessage::create(DeprecationMessageSource,
WarningMessageLevel, "Request.context is deprecated and will be removed in
M46."));
On 2015/08/13 11:45:11, falken wrote:
> On 2015/08/13 11:39:10, hiroshige wrote:
> > On 2015/08/13 11:37:19, falken wrote:
> > > Deprecation messages are usually added to UseCounter.cpp:
> > >
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> > > 
> > 
> > Hmm, so we should add a new use counter and corresponding deprecation
message,
> > right?
> 
> I think that's the convention, that's what I did for Client.postMessage:
> https://codereview.chromium.org/925293002
> 
> This also means the author doesn't get spammed with deprecation warnings if
they
> use the feature multiple times in a page.

Done.

[falken, 2015-08-14 00:27:13]

lgtm thanks

[hiroshige, 2015-08-14 11:13:56]

hiroshige@chromium.org changed reviewers:
+ kinuko@chromium.org

[hiroshige, 2015-08-14 11:13:56]

+kinuko@, could you take a look at as a core/ owner?

Also, are the changes in UseCounter.h/cpp safe to merge into M-45?

[falken, 2015-08-14 11:28:28]

On 2015/08/14 11:13:56, hiroshige (ooo zombie) wrote:
> +kinuko@, could you take a look at as a core/ owner?
> 
> Also, are the changes in UseCounter.h/cpp safe to merge into M-45?

Sorry I overlooked something. I think the deprecation should be in the IDL file
itself, like
https://codereview.chromium.org/925293002/diff/1/Source/modules/serviceworker...
did.

[hiroshige, 2015-08-14 11:40:36]

On 2015/08/14 11:28:28, falken wrote:
> On 2015/08/14 11:13:56, hiroshige (ooo zombie) wrote:
> > +kinuko@, could you take a look at as a core/ owner?
> > 
> > Also, are the changes in UseCounter.h/cpp safe to merge into M-45?
> 
> Sorry I overlooked something. I think the deprecation should be in the IDL
file
> itself, like
>
https://codereview.chromium.org/925293002/diff/1/Source/modules/serviceworker...
> did.

Oh, thanks!
Fixed in Patch Set 5 (http/tests/fetch tests are OK locally, testing other on
trybots).

[falken, 2015-08-14 11:49:00]

sorry another thing: the deprecation warning should probably give a hint to
developers about what to use instead. i recommend a link to
https://www.chromestatus.com/feature/5534702526005248 (like done here:
https://codereview.chromium.org/1228303002/diff/1/Source/core/frame/UseCounte...),
which we can update without committing code changes.

still lgtm

[hiroshige, 2015-08-14 12:04:11]

On 2015/08/14 11:49:00, falken wrote:
> sorry another thing: the deprecation warning should probably give a hint to
> developers about what to use instead.
Sounds good. Uploaded Patch Set 6.
Also agree that providing the link is useful, because at this time we just
remove Request.context and don't implement alternatives yet, thus we have to
update the status later.

[kinuko, 2015-08-14 15:13:39]

lgtm

I think we could try requesting merge.

[kinuko, 2015-08-14 15:13:51]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2015-08-14 15:13:51]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1287273002/#ps100001
(title: "Provide a link in messages.")

[commit-bot: I haz the power, 2015-08-14 15:14:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287273002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287273002/100001

[commit-bot: I haz the power, 2015-08-14 18:06:31]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200553