Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 925293002: Service Worker: Add a warning message for Client.postMessage (Closed)

Created:
5 years, 10 months ago by falken
Modified:
5 years, 10 months ago
Reviewers:
kinuko
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, jakearchibald
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Service Worker: Add a warning message for Client.postMessage The API is under discussion and likely to change in a breaking way. Let users know this. Discussion is at: https://github.com/slightlyoff/ServiceWorker/issues/609 BUG=457094 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190286

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/Client.idl View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
falken
kinuko: PTAL jake: FYI
5 years, 10 months ago (2015-02-16 08:24:21 UTC) #2
kinuko
lgtm
5 years, 10 months ago (2015-02-16 11:43:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/925293002/1
5 years, 10 months ago (2015-02-17 01:06:37 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 01:10:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190286

Powered by Google App Engine
This is Rietveld 408576698