Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1287263007: clang/win: Fix component builds after https://codereview.chromium.org/1272113002 (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M url/url_util.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Nico
An enum is just a symbolic constant without linkage. Exporting it doesn't have an effect, ...
5 years, 4 months ago (2015-08-19 15:55:54 UTC) #2
Nico
Committed patchset #1 (id:1) manually as 204f0a762771bccf7f7d5e8858c0baa1b78733f3 (presubmit successful).
5 years, 4 months ago (2015-08-19 15:59:28 UTC) #3
tyoshino (SeeGerritForStatus)
5 years, 4 months ago (2015-08-20 02:29:39 UTC) #4
Message was sent while issue was closed. 
Thanks for taking care of this! lgtm

Powered by Google App Engine
This is Rietveld 408576698