Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1287173002: X87: [compiler] Remove broken support for undetectable strings. (Closed)

Created:
5 years, 4 months ago by chunyang.dai
Modified:
5 years, 4 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [compiler] Remove broken support for undetectable strings. port b62dbf1efdec68ae709b0e91d3b7c13171b720c9 (r30132). original commit messge: Support for undetectable strings was officially dropped in https://codereview.chromium.org/916753002, but the compilers weren't fixed properly. BUG= Committed: https://crrev.com/8eeec89b9fee1b268140c6a1c121d6a97339f856 Cr-Commit-Position: refs/heads/master@{#30156}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 4 months ago (2015-08-13 06:29:55 UTC) #2
Weiliang
lgtm
5 years, 4 months ago (2015-08-13 12:58:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287173002/1
5 years, 4 months ago (2015-08-13 12:58:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 13:32:02 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 13:32:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8eeec89b9fee1b268140c6a1c121d6a97339f856
Cr-Commit-Position: refs/heads/master@{#30156}

Powered by Google App Engine
This is Rietveld 408576698