Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 12871015: SIMD plumbing (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix FPU register move instruction on x64 Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_x64.cc
diff --git a/runtime/vm/flow_graph_compiler_x64.cc b/runtime/vm/flow_graph_compiler_x64.cc
index 30c751c2043491aa1ebca566bc6e66d5b5ea2987..6a580c960998197d83cdd3ea86af8d480e2f487a 100644
--- a/runtime/vm/flow_graph_compiler_x64.cc
+++ b/runtime/vm/flow_graph_compiler_x64.cc
@@ -1336,18 +1336,18 @@ void FlowGraphCompiler::SaveLiveRegisters(LocationSummary* locs) {
// TODO(vegorov): consider saving only caller save (volatile) registers.
const intptr_t xmm_regs_count = locs->live_registers()->fpu_regs_count();
if (xmm_regs_count > 0) {
- __ subq(RSP, Immediate(xmm_regs_count * kDoubleSize));
+ __ subq(RSP, Immediate(xmm_regs_count * kFpuRegisterSize));
// Store XMM registers with the lowest register number at the lowest
// address.
intptr_t offset = 0;
for (intptr_t reg_idx = 0; reg_idx < kNumberOfXmmRegisters; ++reg_idx) {
XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx);
if (locs->live_registers()->ContainsFpuRegister(xmm_reg)) {
- __ movsd(Address(RSP, offset), xmm_reg);
- offset += kDoubleSize;
+ __ movups(Address(RSP, offset), xmm_reg);
+ offset += kFpuRegisterSize;
}
}
- ASSERT(offset == (xmm_regs_count * kDoubleSize));
+ ASSERT(offset == (xmm_regs_count * kFpuRegisterSize));
}
// Store general purpose registers with the highest register number at the
@@ -1378,11 +1378,11 @@ void FlowGraphCompiler::RestoreLiveRegisters(LocationSummary* locs) {
for (intptr_t reg_idx = 0; reg_idx < kNumberOfXmmRegisters; ++reg_idx) {
XmmRegister xmm_reg = static_cast<XmmRegister>(reg_idx);
if (locs->live_registers()->ContainsFpuRegister(xmm_reg)) {
- __ movsd(xmm_reg, Address(RSP, offset));
- offset += kDoubleSize;
+ __ movups(xmm_reg, Address(RSP, offset));
+ offset += kFpuRegisterSize;
}
}
- ASSERT(offset == (xmm_regs_count * kDoubleSize));
+ ASSERT(offset == (xmm_regs_count * kFpuRegisterSize));
__ addq(RSP, Immediate(offset));
}
}

Powered by Google App Engine
This is Rietveld 408576698