Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1287043004: Use CapabilityFilter to restrict what HTMLViewers can connect to. (Closed)

Created:
5 years, 4 months ago by Ben Goodger (Google)
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use CapabilityFilter to restrict what HTMLViewers can connect to. R=sky@chromium.org http://crbug.com/510210 Committed: https://crrev.com/2c93465a31b1b1bea14cdb251a947ac9051063e8 Cr-Commit-Position: refs/heads/master@{#343284}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 1

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -13 lines) Patch
M mandoline/tab/BUILD.gn View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -0 lines 0 comments Download
M mandoline/tab/DEPS View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -0 lines 0 comments Download
M mandoline/tab/frame_connection.cc View 1 2 3 4 5 6 7 8 2 chunks +53 lines, -1 line 0 comments Download
M mojo/application/public/cpp/application_impl.h View 1 2 3 4 5 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/application/public/cpp/lib/application_impl.cc View 1 2 3 4 5 1 chunk +8 lines, -2 lines 0 comments Download
M mojo/application/public/cpp/lib/service_registry.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/application_instance.cc View 1 2 3 4 5 6 7 4 chunks +21 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (10 generated)
Ben Goodger (Google)
5 years, 4 months ago (2015-08-12 20:08:32 UTC) #1
sky
https://codereview.chromium.org/1287043004/diff/60001/mandoline/tab/frame_connection.cc File mandoline/tab/frame_connection.cc (right): https://codereview.chromium.org/1287043004/diff/60001/mandoline/tab/frame_connection.cc#newcode30 mandoline/tab/frame_connection.cc:30: network_service_interfaces.push_back("mojo::NetworkService"); This strikes me as very fragile. If someone ...
5 years, 4 months ago (2015-08-12 20:36:16 UTC) #2
Ben Goodger (Google)
PTAL
5 years, 4 months ago (2015-08-12 20:55:13 UTC) #3
sky
LGTM
5 years, 4 months ago (2015-08-12 21:12:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287043004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287043004/100001
5 years, 4 months ago (2015-08-12 21:37:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/120609)
5 years, 4 months ago (2015-08-12 23:28:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287043004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287043004/100001
5 years, 4 months ago (2015-08-13 03:34:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/120737)
5 years, 4 months ago (2015-08-13 05:28:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287043004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287043004/120001
5 years, 4 months ago (2015-08-13 17:26:25 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/120932)
5 years, 4 months ago (2015-08-13 19:11:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287043004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287043004/160001
5 years, 4 months ago (2015-08-13 21:00:13 UTC) #21
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 4 months ago (2015-08-13 22:04:09 UTC) #22
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 22:04:39 UTC) #23
Message was sent while issue was closed. 
Patchset 9 (id:??) landed as
https://crrev.com/2c93465a31b1b1bea14cdb251a947ac9051063e8
Cr-Commit-Position: refs/heads/master@{#343284}

Powered by Google App Engine
This is Rietveld 408576698