Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: mojo/application/public/cpp/application_impl.h

Issue 1287043004: Use CapabilityFilter to restrict what HTMLViewers can connect to. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mandoline/tab/frame_connection.cc ('k') | mojo/application/public/cpp/lib/application_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/application/public/cpp/application_impl.h
diff --git a/mojo/application/public/cpp/application_impl.h b/mojo/application/public/cpp/application_impl.h
index b2e9675ade244a744a84ea500e26f59ddd736c23..9b587b283dae6765f725f2f3b00609b3fd1f3a3f 100644
--- a/mojo/application/public/cpp/application_impl.h
+++ b/mojo/application/public/cpp/application_impl.h
@@ -94,11 +94,10 @@ class ApplicationImpl : public Application {
// Requests a new connection to an application. Returns a pointer to the
// connection if the connection is permitted by this application's delegate,
// or nullptr otherwise. Caller takes ownership.
- // TODO(beng): consider replacing default value in a separate CL per style
- // guide.
- scoped_ptr<ApplicationConnection> ConnectToApplication(
+ scoped_ptr<ApplicationConnection> ConnectToApplication(URLRequestPtr request);
+ scoped_ptr<ApplicationConnection> ConnectToApplicationWithCapabilityFilter(
URLRequestPtr request,
- CapabilityFilterPtr filter = nullptr);
+ CapabilityFilterPtr filter);
// Connect to application identified by |request->url| and connect to the
// service implementation of the interface identified by |Interface|.
« no previous file with comments | « mandoline/tab/frame_connection.cc ('k') | mojo/application/public/cpp/lib/application_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698