Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 1286993006: Introduce isRenderedCharacter(Position) function (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce isRenderedCharacter(Position) function This patch introduces |isRenderedCharacter(Position)()| as replacement of |PositionAlgorithm<Strategy>::isRenderedCharacter()| to simplify source code for improving code health, since |isRenderedCharacter()| is used only for positions in DOM tree, thus we don't need to have composed tree version. This patch is a part of |Position| class cleanup to reduce |LayoutObject| dependency. BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200801

Patch Set 1 : 2015-08-19T12:39:43 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M Source/core/editing/Position.h View 2 chunks +6 lines, -1 line 0 comments Download
M Source/core/editing/Position.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M Source/core/editing/commands/DeleteSelectionCommand.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/editing/commands/InsertLineBreakCommand.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 04:03:15 UTC) #2
hajimehoshi
lgtm
5 years, 4 months ago (2015-08-19 04:29:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286993006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286993006/1
5 years, 4 months ago (2015-08-19 04:39:29 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 06:11:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200801

Powered by Google App Engine
This is Rietveld 408576698