Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1286773002: mandoline: Sandbox mojo:browser and mojo:omnibox. (Closed)

Created:
5 years, 4 months ago by Elliot Glaysher
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mandoline: Reland "Sandbox mojo:browser and mojo:omnibox." This is a straight reland of the previous patch; as the manual usage of icu was removed in https://codereview.chromium.org/1281343003/. BUG=492524 Previous Review URL: https://codereview.chromium.org/1282903002 TBR=jam@chromium.org Committed: https://crrev.com/a44b5ebab57a94c3ad673128b5d9da90e94a33aa Cr-Commit-Position: refs/heads/master@{#343765}

Patch Set 1 #

Patch Set 2 : What state? #

Patch Set 3 : Reapply original patch without any modifications. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -9 lines) Patch
M components/font_service/public/cpp/font_loader.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/font_service/public/cpp/font_loader.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M mandoline/app/core_services_initialization.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/services/core_services/main.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M mandoline/ui/aura/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M mandoline/ui/aura/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/ui/aura/aura_init.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Elliot Glaysher
5 years, 4 months ago (2015-08-17 21:11:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286773002/40001
5 years, 4 months ago (2015-08-17 21:12:09 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-17 22:48:31 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 22:49:16 UTC) #6
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a44b5ebab57a94c3ad673128b5d9da90e94a33aa
Cr-Commit-Position: refs/heads/master@{#343765}

Powered by Google App Engine
This is Rietveld 408576698