Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1282903002: mandoline: Sandbox mojo:browser and mojo:omnibox. (Closed)

Created:
5 years, 4 months ago by Elliot Glaysher
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mandoline: Sandbox mojo:browser and mojo:omnibox. BUG=492524 Committed: https://crrev.com/7cd4b784ffd31856b32ada4efd2265a4989fd575 Cr-Commit-Position: refs/heads/master@{#342725}

Patch Set 1 #

Patch Set 2 : Patch touch ups. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -9 lines) Patch
M components/font_service/public/cpp/font_loader.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/font_service/public/cpp/font_loader.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M mandoline/app/core_services_initialization.cc View 3 chunks +5 lines, -4 lines 2 comments Download
M mandoline/services/core_services/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/services/core_services/main.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M mandoline/ui/aura/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M mandoline/ui/aura/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/ui/aura/aura_init.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Elliot Glaysher
https://codereview.chromium.org/1282903002/diff/20001/mandoline/app/core_services_initialization.cc File mandoline/app/core_services_initialization.cc (left): https://codereview.chromium.org/1282903002/diff/20001/mandoline/app/core_services_initialization.cc#oldcode41 mandoline/app/core_services_initialization.cc:41: GURL("mojo:tracing"), GURL("mojo:core_services"), "Sandboxed Core"); Renamed "Sandboxed Core" back to ...
5 years, 4 months ago (2015-08-10 21:00:16 UTC) #2
jam
lgtm
5 years, 4 months ago (2015-08-10 22:27:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282903002/20001
5 years, 4 months ago (2015-08-10 22:30:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-10 23:06:02 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7cd4b784ffd31856b32ada4efd2265a4989fd575 Cr-Commit-Position: refs/heads/master@{#342725}
5 years, 4 months ago (2015-08-10 23:06:44 UTC) #7
Fady Samuel
5 years, 4 months ago (2015-08-11 15:21:42 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1274993003/ by fsamuel@chromium.org.

The reason for reverting is: This broke --enable-multiprocess on mandoline..

Powered by Google App Engine
This is Rietveld 408576698