Chromium Code Reviews| Index: build/android/gyp/javac.py |
| diff --git a/build/android/gyp/javac.py b/build/android/gyp/javac.py |
| index dafe5dff0ab9a9f767c3105641283fa30a84cdaf..0913a0ea59b6ecfd487f20879d8f0db374472f16 100755 |
| --- a/build/android/gyp/javac.py |
| +++ b/build/android/gyp/javac.py |
| @@ -55,14 +55,19 @@ def ColorJavacOutput(output): |
| ERRORPRONE_OPTIONS = [ |
| - '-Xepdisable:' |
| # Something in chrome_private_java makes this check crash. |
| - 'com.google.errorprone.bugpatterns.ClassCanBeStatic,' |
| + '-Xep:ClassCanBeStatic:WARN', |
| # These crash on lots of targets. |
| - 'com.google.errorprone.bugpatterns.WrongParameterPackage,' |
| - 'com.google.errorprone.bugpatterns.GuiceOverridesGuiceInjectableMethod,' |
| - 'com.google.errorprone.bugpatterns.GuiceOverridesJavaxInjectableMethod,' |
| - 'com.google.errorprone.bugpatterns.ElementsCountedInLoop' |
| + '-Xep:ParameterPackage:OFF', |
| + '-Xep:OverridesGuiceInjectableMethod:OFF', |
| + '-Xep:OverridesJavaxInjectableMethod:OFF', |
| + '-Xep:ElementsCountedInLoop:WARN', |
| + # TODO(mikecase): Remove these flags once issues have been fixed. These |
| + # errors are present and causing errorprone builds to fail early. Setting to |
| + # warn so we can see more errors that occur later in the build. |
|
Nico
2015/08/17 20:55:34
Builds should be silent, else people learn to tole
mikecase (-- gone --)
2015/08/19 23:29:29
Fixed.
Have a few CLs to fix errors/warnings I go
|
| + '-Xep:DepAnn:WARN', |
| + '-Xep:JUnit4TestNotRun:WARN', |
| + '-Xep:NarrowingCompoundAssignment:WARN', |
| ] |
| def DoJavac( |