Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 1286593003: [Password Manager] Store forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Vaclav's Review Comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 755e4e1dfd03586b8aecf37c5fc3e1ac7fe29b13..e9beb7350d5b3e4e6cc49bb639f3f0850ceaef80 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -235,16 +235,6 @@ bool PasswordFormManager::IsPendingCredentialsPublicSuffixMatch() const {
return pending_credentials_.IsPublicSuffixMatch();
}
-bool PasswordFormManager::HasValidPasswordForm() const {
- DCHECK(state_ == MATCHING_PHASE || state_ == POST_MATCHING_PHASE) << state_;
- // Non-HTML password forms (primarily HTTP and FTP autentication)
- // do not contain username_element and password_element values.
- if (observed_form_.scheme != PasswordForm::SCHEME_HTML)
- return true;
- return !observed_form_.password_element.empty() ||
- !observed_form_.new_password_element.empty();
-}
-
void PasswordFormManager::ProvisionallySave(
const PasswordForm& credentials,
OtherPossibleUsernamesAction action) {

Powered by Google App Engine
This is Rietveld 408576698