components/password_manager/core/browser/password_form_manager.h - Issue 1286593003: [Password Manager] Store forms with field name and id attributes missing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.h

Issue 1286593003: [Password Manager] Store forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Vaclav's Review Comments. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_form_conversion_utils.cc ('K') | « components/autofill/content/renderer/password_form_conversion_utils.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.h

diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h

index e56cf3f82c8f5f17dc9a7e691f82fe553b465770..f8aaaf301cf9c14174c78031aa4beb1d2fd1b6df 100644

--- a/components/password_manager/core/browser/password_form_manager.h

+++ b/components/password_manager/core/browser/password_form_manager.h

@@ -113,10 +113,6 @@ class PasswordFormManager : public PasswordStoreConsumer {

// form.

bool IsPendingCredentialsPublicSuffixMatch() const;

- // Checks if the form is a valid password form. Forms which lack password

- // field are not considered valid.

- bool HasValidPasswordForm() const;

// Through |driver|, supply the associated frame with appropriate information

// (fill data, whether to allow password generation, etc.). If this is called

// before |this| has data from the PasswordStore, the execution will be