Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 1286593003: [Password Manager] Store forms with field name and id attributes missing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Vivek's Review Comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.h
diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h
index a474d46860eacd5360c722a2014a33aced11de84..a5e9cb5674a5c0b3d3eef594ebcc06223837527a 100644
--- a/components/password_manager/core/browser/password_manager.h
+++ b/components/password_manager/core/browser/password_manager.h
@@ -120,6 +120,14 @@ class PasswordManager : public LoginModel {
PasswordManagerClient* client() { return client_; }
+ // Returns true if this form has PasswordFormManager objects created and
+ // stored in |pending_login_managers_| collection. For non-password forms
+ // PasswordFormManager objects wont be created and this collection shall be
+ // empty.
+ bool HasPendingLoginManagerForTesting() {
+ return pending_login_managers_.size();
+ }
+
private:
enum ProvisionalSaveFailure {
SAVING_DISABLED,

Powered by Google App Engine
This is Rietveld 408576698