[Password Manager] Store forms with field name and id attributes missing.

chrome/browser/password_manager/password_manager_browsertest.cc

Index: chrome/browser/password_manager/password_manager_browsertest.cc
diff --git a/chrome/browser/password_manager/password_manager_browsertest.cc b/chrome/browser/password_manager/password_manager_browsertest.cc
index 6a1f0b8c3d1bf7a86ea39317e89351d79a8fa5a4..a2a7457f0302915c3c38a06edb9e0d834bbbb8da 100644
--- a/chrome/browser/password_manager/password_manager_browsertest.cc
+++ b/chrome/browser/password_manager/password_manager_browsertest.cc
@@ -893,8 +893,8 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
 }
 
 IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
-                       NoPromptForInputElementWithoutIdAndName) {
-  // Check that no prompt is shown for forms where the input fields lack both
+                       PromptForInputElementWithoutIdAndName) {
+  // Check that prompt is shown for forms where the input fields lack both
   // the "id" and the "name" attributes.
   NavigateToFile("/password/password_form.html");
 
@@ -910,7 +910,7 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
       "form.children[2].click()";  // form.children[2] is the submit button.
   ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));
   observer.Wait();
-  EXPECT_FALSE(prompt_observer->IsShowingPrompt());
+  EXPECT_TRUE(prompt_observer->IsShowingPrompt());
 }
 
 // Test for checking that no prompt is shown for URLs with file: scheme.
@@ -2126,4 +2126,23 @@ IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
 }
 #endif
 
+// Test that loading a non-password form will not create a PasswordFormManager

[vabr (Chromium), 2015/08/15 17:23:01]

I don't think you need an end-to-end test for this. Please replace it with just
testing that a HTML form without password fields produces no PasswordForm, in
password_form_conversion_utils_browsertest.cc.

Once you do this, please remove
PasswordManager::HasPendingLoginManagerForTesting() again.

[Pritam Nikam, 2015/08/18 14:04:13]

Done.
I've removed this test.

We already have this test-case
|MAYBE_PasswordFormConversionUtilsTest.InvalidFormDueToNoPasswordFields| for
coverage, testing that a HTML form without password fields produces no
PasswordForm.

+// instance.
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTestBase,
+                       NoPasswordFormManagerForNonPasswordForms) {
+  password_manager::PasswordManager* password_manager =
+      ChromePasswordManagerClient::FromWebContents(WebContents())
+          ->GetPasswordManager();
+
+  // Verify that the PasswordFormManager will get instantiated post a password

[vabr (Chromium), 2015/08/15 17:23:01]

nit: The comments are redundant, the code is short and clear. Please drop lines
2137-2138 and 2142-2143.

[Pritam Nikam, 2015/08/18 14:04:13]

Done.

+  // form navigation.
+  NavigateToFile("/password/password_form.html");
+  EXPECT_TRUE(password_manager->HasPendingLoginManagerForTesting());
+
+  // Verify that none PasswordFormManager instace will exist post a non-password
+  // form navigation.
+  NavigateToFile("/password/non_password_form.html");
+  EXPECT_FALSE(password_manager->HasPendingLoginManagerForTesting());
+}
+
 }  // namespace password_manager