Stop setting --enable-overlay-fullscreen-video on Android

Stop setting --enable-overlay-fullscreen-video on Android

Previously, --enable-overlay-fullscreen-video was used to enable the
blink runtime feature OverlayFullscreenVideo which enabled video to be
efficiently {over,under}-layed on Android. This was set by default on
Android and for layout tests on other platforms. Now the WebMediaPlayer
decides whether overlay fullscreen mode will be used. The blink runtime
feature is renamed to ForceOverlayFullscreenVideo to be used as an
override for running the overlay fullscreen layout tests on non-android
platforms.

This relies on blink changes:
  * https://codereview.chromium.org/1254613003
  * https://codereview.chromium.org/1278583004

A follow up change will remove the OverlayFullscreenVideo runtime
feature and corresponding command line flag.

BUG=511376, 507834
TEST=virtual/android/fullscreen layout tests, manual

Committed: https://crrev.com/fdd36a8329fb60fc5c50612643e310cc40204f07
Cr-Commit-Position: refs/heads/master@{#343064}

[watk, 2015-08-10 23:12:33]

watk@chromium.org changed reviewers:
+ lcwu@chromium.org, qinmin@chromium.org

[watk, 2015-08-10 23:12:33]

lcwu@chromium.org: Please review changes in chromecast/

qinmin@chromium.org: Please review changes in webmediaplayer_android.{cc,h}

[gunsch, 2015-08-10 23:14:48]

gunsch@chromium.org changed reviewers:
+ gunsch@chromium.org
- lcwu@chromium.org

[gunsch, 2015-08-10 23:17:25]

(taking over for lcwu)

lgtm, looks like this should generally be a no-op for Android builds that set
this command line flag?

[watk, 2015-08-10 23:44:05]

On 2015/08/10 23:17:25, gunsch wrote:
> (taking over for lcwu)
> 
> lgtm, looks like this should generally be a no-op for Android builds that set
> this command line flag?

This change shouldn't change any behavior. It just changes how we specify the
overlay mode and where we were previously setting the flag, we should be using
WebMediaPlayerAndroid which returns true from supportsOverlayFullscreenVideo()
I'm not sure if that answers your question though?

[gunsch, 2015-08-11 00:05:49]

Yeah, that was my understanding reading through the code as well, just looking
to confirm. Thanks.

[qinmin, 2015-08-11 17:41:13]

lgtm

[watk, 2015-08-11 18:27:33]

watk@chromium.org changed reviewers:
+ nick@chromium.org, yfriedman@chromium.org

[watk, 2015-08-11 18:27:34]

yfriedman@chromium.org: Please review changes in
content/browser/android/content_startup_flags.cc

nick@chromium.org: Please review changes in content/

[ncarter (slow), 2015-08-11 20:44:28]

lgtm

[watk, 2015-08-12 17:44:17]

The CQ bit was checked by watk@chromium.org

[watk, 2015-08-12 17:44:17]

The patchset sent to the CQ was uploaded after l-g-t-m from gunsch@chromium.org
Link to the patchset: https://codereview.chromium.org/1286583002/#ps40001
(title: "forgot namespace")

[commit-bot: I haz the power, 2015-08-12 17:44:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1286583002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1286583002/40001

[commit-bot: I haz the power, 2015-08-12 18:45:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-12 18:45:44]

Patchset 3 (id:??) landed as
https://crrev.com/fdd36a8329fb60fc5c50612643e310cc40204f07
Cr-Commit-Position: refs/heads/master@{#343064}