Undo overlay fullscreen video background transparency

Restore background transparency when leaving fullscreen video

This is a follow up to https://codereview.chromium.org/1254613003 which
removes a usage of OverlayFullscreenVideo that was missed. Previously
the overlay fullscreen runtime feature was used to decide
whether to restore background transparency when leaving fullscreen. Now
it's done whenever the fullscreen element is a video, because we
don't know whether the WebMediaPlayer belonging to the video element used
the overlay mode or not. So conservatively restore the state.

This also adds a setter for ForceOverlayFullscreenVideo to pave the
way for a chromium change to replace usages of OverlayFullscreenVideo
with it.

BUG=511376, 507834
TEST=virtual/android/fullscreen layout tests

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200193

[watk, 2015-08-07 02:25:25]

Patchset #1 (id:1) has been deleted

[watk, 2015-08-07 02:32:45]

watk@chromium.org changed reviewers:
+ japhet@chromium.org

[watk, 2015-08-07 02:32:45]

Hi japhet@, please take a look.

[Nate Chapin, 2015-08-07 17:12:31]

LGTM. I assume the old runtime flag will be removed soon?

https://codereview.chromium.org/1278583004/diff/20001/LayoutTests/fullscreen/...
File
LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html
(right):

https://codereview.chromium.org/1278583004/diff/20001/LayoutTests/fullscreen/...
LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html:27:
if (window.internals.runtimeFlags.overlayFullscreenVideoEnabled ||
window.internals.runtimeFlags.forceOverlayFullscreenVideoEnabled )
Nit: unnecessary trailing space.

[watk, 2015-08-07 19:02:40]

Thanks japhet@, yes I'll be removing the old runtime flag soon.

https://codereview.chromium.org/1278583004/diff/20001/LayoutTests/fullscreen/...
File
LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html
(right):

https://codereview.chromium.org/1278583004/diff/20001/LayoutTests/fullscreen/...
LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls.html:27:
if (window.internals.runtimeFlags.overlayFullscreenVideoEnabled ||
window.internals.runtimeFlags.forceOverlayFullscreenVideoEnabled )
On 2015/08/07 17:12:31, Nate Chapin wrote:
> Nit: unnecessary trailing space.

Done.

[watk, 2015-08-07 19:02:56]

The CQ bit was checked by watk@chromium.org

[watk, 2015-08-07 19:02:56]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org
Link to the patchset: https://codereview.chromium.org/1278583004/#ps40001
(title: "Remove extraneous space")

[commit-bot: I haz the power, 2015-08-07 19:03:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278583004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278583004/40001

[commit-bot: I haz the power, 2015-08-07 20:26:39]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200193