Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1286403002: Make object.h usable without object-inl.h header. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make object.h usable without object-inl.h header. This CL us a pure refactoring that makes an empty compilation unit including just "object.h" but not "object-inl.h" compile without warnings or errors. This is needed to further reduce the header dependency tangle. R=bmeurer@chromium.org Committed: https://crrev.com/40c11d060c13885263338645990c22aab23f197d Cr-Commit-Position: refs/heads/master@{#30152}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+881 lines, -547 lines) Patch
M src/objects.h View 41 chunks +184 lines, -509 lines 0 comments Download
M src/objects-inl.h View 1 32 chunks +697 lines, -38 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-13 11:03:26 UTC) #1
Benedikt Meurer
LGTM (rubberstamped)
5 years, 4 months ago (2015-08-13 11:05:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286403002/20001
5 years, 4 months ago (2015-08-13 11:24:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-13 11:49:06 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 11:49:16 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/40c11d060c13885263338645990c22aab23f197d
Cr-Commit-Position: refs/heads/master@{#30152}

Powered by Google App Engine
This is Rietveld 408576698