Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1288053004: Remove inline header includes from non-inline headers (2). (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-object
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove inline header includes from non-inline headers (2). This tries to remove includes of "-inl.h" headers from normal ".h" headers, thereby reducing the chance of any cyclic dependencies and decreasing the average size of our compilation units. Note that this change still leaves 5 violations of that rule in the code. It only tackles "node.h" including "types-inl.h". R=titzer@chromium.org Committed: https://crrev.com/4b340c893340aed3632d51627522cb8b0b205061 Cr-Commit-Position: refs/heads/master@{#30161}

Patch Set 1 #

Patch Set 2 : Fix GCC compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -7 lines) Patch
M src/compiler/common-node-cache.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-frame-specialization.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/js-type-feedback-lowering.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/node.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/source-position.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/conversions.h View 1 2 chunks +4 lines, -6 lines 0 comments Download
M src/conversions-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/sampler.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
The actual change is in src/compiler/node.h, the rest is fallout from missing IWYU in other ...
5 years, 4 months ago (2015-08-13 14:04:31 UTC) #1
titzer
On 2015/08/13 14:04:31, Michael Starzinger wrote: > The actual change is in src/compiler/node.h, the rest ...
5 years, 4 months ago (2015-08-13 14:10:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288053004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288053004/20001
5 years, 4 months ago (2015-08-13 15:28:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-13 15:30:09 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 15:30:26 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4b340c893340aed3632d51627522cb8b0b205061
Cr-Commit-Position: refs/heads/master@{#30161}

Powered by Google App Engine
This is Rietveld 408576698