src/compiler/ast-graph-builder.cc - Issue 1286383005: Parse arrow functions at proper precedence level

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-graph-builder.cc

Issue 1286383005: Parse arrow functions at proper precedence level (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master

Patch Set: Add test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-graph-builder.cc

diff --git a/src/compiler/ast-graph-builder.cc b/src/compiler/ast-graph-builder.cc

index e7725799233cbb63136c4bc73473c440d7463f95..bab7eeda7e96337605adce8cac6f546d47f93d8e 100644

--- a/src/compiler/ast-graph-builder.cc

+++ b/src/compiler/ast-graph-builder.cc

@@ -2867,6 +2867,12 @@ void AstGraphBuilder::VisitSpread(Spread* expr) {

}

+void AstGraphBuilder::VisitEmptyParentheses(EmptyParentheses* expr) {

+ // Handled entirely by the parser itself.

+ UNREACHABLE();

void AstGraphBuilder::VisitThisFunction(ThisFunction* expr) {

Node* value = GetFunctionClosure();

ast_context()->ProduceValue(value);