Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1286373004: Treat win8 machines as win10 ports and remove baseline/specifier support. (Closed)

Created:
5 years, 4 months ago by joelo
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke, jsbell, ojan
CC:
blink-reviews, leviw_travelin_and_unemployed
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Treat win8 machines as win10 ports and remove baseline/specifier support. BUG=521704, 496259 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -26 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 2 chunks +2 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/builders.py View 2 chunks +0 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py View 1 chunk +0 lines, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 chunk +0 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/win.py View 2 chunks +4 lines, -6 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py View 3 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
joelo
ptal :)
5 years, 4 months ago (2015-08-17 20:45:15 UTC) #2
Dirk Pranke
lgtm, though if it doesn't work on win8 at all, we might want to fail ...
5 years, 4 months ago (2015-08-17 20:47:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286373004/1
5 years, 4 months ago (2015-08-17 20:52:08 UTC) #5
joelo
On 2015/08/17 20:47:30, Dirk Pranke wrote: > lgtm, though if it doesn't work on win8 ...
5 years, 4 months ago (2015-08-17 20:59:36 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 23:10:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200679

Powered by Google App Engine
This is Rietveld 408576698