Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py

Issue 1286373004: Treat win8 machines as win10 ports and remove baseline/specifier support. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 cls=linux.LinuxPort) 67 cls=linux.LinuxPort)
68 68
69 def test_android(self): 69 def test_android(self):
70 self.assert_port(port_name='android', cls=android.AndroidPort) 70 self.assert_port(port_name='android', cls=android.AndroidPort)
71 # NOTE: We can't check for port_name=chromium here, as this will append the host's 71 # NOTE: We can't check for port_name=chromium here, as this will append the host's
72 # operating system, whereas host!=target for Android. 72 # operating system, whereas host!=target for Android.
73 73
74 def test_win(self): 74 def test_win(self):
75 self.assert_port(port_name='win-xp', cls=win.WinPort) 75 self.assert_port(port_name='win-xp', cls=win.WinPort)
76 self.assert_port(port_name='win-win7', cls=win.WinPort) 76 self.assert_port(port_name='win-win7', cls=win.WinPort)
77 self.assert_port(port_name='win-win8', cls=win.WinPort)
78 self.assert_port(port_name='win-win10', cls=win.WinPort) 77 self.assert_port(port_name='win-win10', cls=win.WinPort)
79 self.assert_port(port_name='win', os_name='win', os_version='xp', 78 self.assert_port(port_name='win', os_name='win', os_version='xp',
80 cls=win.WinPort) 79 cls=win.WinPort)
81 self.assert_port(port_name='chromium', os_name='win', os_version='xp', 80 self.assert_port(port_name='chromium', os_name='win', os_version='xp',
82 cls=win.WinPort) 81 cls=win.WinPort)
83 82
84 def test_unknown_specified(self): 83 def test_unknown_specified(self):
85 self.assertRaises(NotImplementedError, factory.PortFactory(MockSystemHos t()).get, port_name='unknown') 84 self.assertRaises(NotImplementedError, factory.PortFactory(MockSystemHos t()).get, port_name='unknown')
86 85
87 def test_unknown_default(self): 86 def test_unknown_default(self):
88 self.assertRaises(NotImplementedError, factory.PortFactory(MockSystemHos t(os_name='vms')).get) 87 self.assertRaises(NotImplementedError, factory.PortFactory(MockSystemHos t(os_name='vms')).get)
89 88
90 def test_get_from_builder_name(self): 89 def test_get_from_builder_name(self):
91 self.assertEqual(factory.PortFactory(MockSystemHost()).get_from_builder_ name('WebKit Mac10.7').name(), 90 self.assertEqual(factory.PortFactory(MockSystemHost()).get_from_builder_ name('WebKit Mac10.7').name(),
92 'mac-lion') 91 'mac-lion')
OLDNEW
« no previous file with comments | « Tools/Scripts/webkitpy/layout_tests/port/builders.py ('k') | Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698