Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Unified Diff: Source/core/inspector/PageDebuggerAgent.cpp

Issue 1286343003: DevTools: make InspectorDebuggerAgent aggregate V8DebuggerAgent instead of inheriting (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed dgozman's comments Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorInstrumentation.idl ('k') | Source/core/inspector/V8DebuggerAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/PageDebuggerAgent.cpp
diff --git a/Source/core/inspector/PageDebuggerAgent.cpp b/Source/core/inspector/PageDebuggerAgent.cpp
index 65b1025d8d6fe7e9ac182f4208703d76096f61d4..8f22a25f7ef14cdf4193c61649624a3e9ac0d0ee 100644
--- a/Source/core/inspector/PageDebuggerAgent.cpp
+++ b/Source/core/inspector/PageDebuggerAgent.cpp
@@ -136,7 +136,7 @@ void PageDebuggerAgent::overlaySteppedOver()
InjectedScript PageDebuggerAgent::defaultInjectedScript()
{
ScriptState* scriptState = ScriptState::forMainWorld(m_pageAgent->inspectedFrame());
- return injectedScriptManager()->injectedScriptFor(scriptState);
+ return m_v8DebuggerAgent->injectedScriptManager()->injectedScriptFor(scriptState);
}
void PageDebuggerAgent::didStartProvisionalLoad(LocalFrame* frame)
@@ -152,12 +152,12 @@ void PageDebuggerAgent::didClearDocumentOfWindowObject(LocalFrame* frame)
// FIXME: what about nested objects?
if (frame != m_pageAgent->inspectedFrame())
return;
- reset();
+ m_v8DebuggerAgent->reset();
}
void PageDebuggerAgent::compileScript(ErrorString* errorString, const String& expression, const String& sourceURL, bool persistScript, const int* executionContextId, TypeBuilder::OptOutput<ScriptId>* scriptId, RefPtr<ExceptionDetails>& exceptionDetails)
{
- InjectedScript injectedScript = injectedScriptForEval(errorString, executionContextId);
+ InjectedScript injectedScript = m_v8DebuggerAgent->injectedScriptForEval(errorString, executionContextId);
if (injectedScript.isEmpty()) {
*errorString = "Inspected frame has gone";
return;
@@ -175,7 +175,7 @@ void PageDebuggerAgent::compileScript(ErrorString* errorString, const String& ex
void PageDebuggerAgent::runScript(ErrorString* errorString, const ScriptId& scriptId, const int* executionContextId, const String* const objectGroup, const bool* const doNotPauseOnExceptionsAndMuteConsole, RefPtr<RemoteObject>& result, RefPtr<ExceptionDetails>& exceptionDetails)
{
- InjectedScript injectedScript = injectedScriptForEval(errorString, executionContextId);
+ InjectedScript injectedScript = m_v8DebuggerAgent->injectedScriptForEval(errorString, executionContextId);
if (injectedScript.isEmpty()) {
*errorString = "Inspected frame has gone";
return;
@@ -187,7 +187,7 @@ void PageDebuggerAgent::runScript(ErrorString* errorString, const ScriptId& scri
TRACE_EVENT1("devtools.timeline", "EvaluateScript", "data", InspectorEvaluateScriptEvent::data(frame, sourceURL, TextPosition::minimumPosition().m_line.oneBasedInt()));
InspectorInstrumentationCookie cookie;
if (frame)
- cookie = InspectorInstrumentation::willEvaluateScript(frame, sourceURL, TextPosition::minimumPosition().m_line.oneBasedInt());
+ cookie = InspectorInstrumentation::willEvaluateScript(frame);
RefPtrWillBeRawPtr<LocalFrame> protect(frame);
InspectorDebuggerAgent::runScript(errorString, scriptId, executionContextId, objectGroup, doNotPauseOnExceptionsAndMuteConsole, result, exceptionDetails);
« no previous file with comments | « Source/core/inspector/InspectorInstrumentation.idl ('k') | Source/core/inspector/V8DebuggerAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698