Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1286203002: Defer flushes if kPreferNoIO is specified (Closed)

Created:
5 years, 4 months ago by robertphillips
Modified:
5 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Defer flushes if kPreferNoIO is specified Prior to this patch clients who were solely uploading to textures (e.g., SW Mask Mgr) would cause extra flushes b.c., even though kPreferNoIO was being specified, resources with pending IO would still be returned even though there was plenty of space in the resource cache. Committed: https://skia.googlesource.com/skia/+/6e83ac778f8f90939abe3aee3ea865428dff592f

Patch Set 1 #

Patch Set 2 : Address code review comments #

Patch Set 3 : cleanup #

Patch Set 4 : use explicit size in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -22 lines) Patch
M include/gpu/GrSurface.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrGpu.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrResourceCache.h View 1 2 chunks +7 lines, -1 line 0 comments Download
M src/gpu/GrResourceCache.cpp View 1 2 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/GrResourceProvider.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrSurface.cpp View 1 1 chunk +29 lines, -0 lines 0 comments Download
M src/gpu/GrTexture.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/gpu/GrTextureProvider.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLRenderTarget.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 3 9 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
robertphillips
5 years, 4 months ago (2015-08-12 16:03:46 UTC) #2
robertphillips
ptal
5 years, 4 months ago (2015-08-12 19:04:31 UTC) #3
bsalomon
On 2015/08/12 19:04:31, robertphillips wrote: > ptal lgtm.
5 years, 4 months ago (2015-08-12 19:46:16 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286203002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286203002/60001
5 years, 4 months ago (2015-08-12 19:54:29 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-12 20:08:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286203002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286203002/60001
5 years, 4 months ago (2015-08-13 12:09:48 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 12:19:17 UTC) #11
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6e83ac778f8f90939abe3aee3ea865428dff592f

Powered by Google App Engine
This is Rietveld 408576698