Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1286133004: A bit of misc cleanup. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

A bit of misc cleanup. - Update comments about skia_shared_lib - Remove dead code (system_preferences) - Remove non-building code (techtalk1) - Turn gm/annotated_text back on. BUG=skia: Committed: https://skia.googlesource.com/skia/+/9a106ba2dd68ced8f6556e99ba211a37439a03bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -450 lines) Patch
D gm/system_preferences.h View 1 chunk +0 lines, -12 lines 0 comments Download
D gm/system_preferences_default.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
D gm/system_preferences_mac.mm View 1 chunk +0 lines, -28 lines 0 comments Download
D gm/techtalk1.cpp View 1 chunk +0 lines, -393 lines 0 comments Download
M gyp/common_conditions.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286133004/1
5 years, 4 months ago (2015-08-14 14:43:45 UTC) #2
mtklein_C
5 years, 4 months ago (2015-08-14 14:48:15 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-14 14:50:39 UTC) #6
hal.canary
lgtm
5 years, 4 months ago (2015-08-14 17:02:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286133004/1
5 years, 4 months ago (2015-08-14 17:03:05 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 17:03:49 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9a106ba2dd68ced8f6556e99ba211a37439a03bb

Powered by Google App Engine
This is Rietveld 408576698