Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: gyp/common_conditions.gypi

Issue 1286133004: A bit of misc cleanup. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gm/techtalk1.cpp ('k') | gyp/gmslides.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 Google Inc. 1 # Copyright 2015 Google Inc.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 # conditions used in both common.gypi and skia.gyp in chromium 6 # conditions used in both common.gypi and skia.gyp in chromium
7 # 7 #
8 { 8 {
9 'defines': [ 9 'defines': [
10 'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)', 10 'SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=<(skia_static_initializers)',
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
315 'cflags': [ 315 'cflags': [
316 # Skia does not enforce this usage pattern so we disable it here to avoi d 316 # Skia does not enforce this usage pattern so we disable it here to avoi d
317 # unecessary log spew when building 317 # unecessary log spew when building
318 '-Wno-unused-parameter', 318 '-Wno-unused-parameter',
319 319
320 # Android's -D_FORTIFY_SOURCE=2 extensions are incompatibile with SkStri ng. 320 # Android's -D_FORTIFY_SOURCE=2 extensions are incompatibile with SkStri ng.
321 # Revert to -D_FORTIFY_SOURCE=1 321 # Revert to -D_FORTIFY_SOURCE=1
322 '-U_FORTIFY_SOURCE', 322 '-U_FORTIFY_SOURCE',
323 '-D_FORTIFY_SOURCE=1', 323 '-D_FORTIFY_SOURCE=1',
324 324
325 # We can't use the skia_shared_library gyp setting because we need to 325 # We can't use the skia_shared_lib gyp setting because we need to
326 # isolate this define to Skia sources. CFLAGS are local to Android.mk 326 # isolate this define to Skia sources. CFLAGS are local to Android.mk
327 # and ensures that this define is not exported to clients of the library 327 # and ensures that this define is not exported to clients of the library
328 '-DSKIA_IMPLEMENTATION=1', 328 '-DSKIA_IMPLEMENTATION=1',
329 ], 329 ],
330 # Remove flags which are either unnecessary or problematic for the 330 # Remove flags which are either unnecessary or problematic for the
331 # Android framework build. Many of these flags are removed simply because 331 # Android framework build. Many of these flags are removed simply because
332 # they were not previously in the Android framework makefile, and we did 332 # they were not previously in the Android framework makefile, and we did
333 # did not intend to add them when generating the makefile. 333 # did not intend to add them when generating the makefile.
334 # TODO (scroggo): Investigate whether any of these flags are actually 334 # TODO (scroggo): Investigate whether any of these flags are actually
335 # needed/would be beneficial. 335 # needed/would be beneficial.
(...skipping 26 matching lines...) Expand all
362 'SK_USE_FREETYPE_EMBOLDEN', 362 'SK_USE_FREETYPE_EMBOLDEN',
363 'SK_SFNTLY_SUBSETTER "sample/chromium/font_subsetter.h"', 363 'SK_SFNTLY_SUBSETTER "sample/chromium/font_subsetter.h"',
364 # When built as part of the system image we can enable certian non-NDK 364 # When built as part of the system image we can enable certian non-NDK
365 # compliant optimizations. 365 # compliant optimizations.
366 'SK_BUILD_FOR_ANDROID_FRAMEWORK', 366 'SK_BUILD_FOR_ANDROID_FRAMEWORK',
367 # Optimizations for chromium (m30) 367 # Optimizations for chromium (m30)
368 'GR_GL_CUSTOM_SETUP_HEADER "gl/GrGLConfig_chrome.h"', 368 'GR_GL_CUSTOM_SETUP_HEADER "gl/GrGLConfig_chrome.h"',
369 'SK_DEFAULT_FONT_CACHE_LIMIT (768 * 1024)', 369 'SK_DEFAULT_FONT_CACHE_LIMIT (768 * 1024)',
370 'SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE (512 * 1024)', 370 'SK_DEFAULT_GLOBAL_DISCARDABLE_MEMORY_POOL_SIZE (512 * 1024)',
371 'SK_IGNORE_ETC1_SUPPORT', 371 'SK_IGNORE_ETC1_SUPPORT',
372 # We can't use the skia_shared_library gyp setting because we need expos e 372 # We can't use the skia_shared_lib gyp setting because we need expose
373 # this define globally and the the implemention define as a cflag. 373 # this define globally and the the implemention define as a cflag.
374 'SKIA_DLL', 374 'SKIA_DLL',
375 'SK_PRINT_CODEC_MESSAGES', 375 'SK_PRINT_CODEC_MESSAGES',
376 ], 376 ],
377 }], 377 }],
378 378
379 ['skia_use_android_framework_defines', { 379 ['skia_use_android_framework_defines', {
380 # Add these defines when building for the Android framework, or when 380 # Add these defines when building for the Android framework, or when
381 # specifically requested. These should be temporary staging defines. Any 381 # specifically requested. These should be temporary staging defines. Any
382 # permanent defines should be moved into the skia_android_framework block 382 # permanent defines should be moved into the skia_android_framework block
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
620 [ 'sknx_no_simd', { 620 [ 'sknx_no_simd', {
621 'defines': [ 'SKNX_NO_SIMD' ], 621 'defines': [ 'SKNX_NO_SIMD' ],
622 }], 622 }],
623 623
624 ], # end 'conditions' 624 ], # end 'conditions'
625 # The Xcode SYMROOT must be at the root. See build/common.gypi in chromium for more details 625 # The Xcode SYMROOT must be at the root. See build/common.gypi in chromium for more details
626 'xcode_settings': { 626 'xcode_settings': {
627 'SYMROOT': '<(DEPTH)/xcodebuild', 627 'SYMROOT': '<(DEPTH)/xcodebuild',
628 }, 628 },
629 } 629 }
OLDNEW
« no previous file with comments | « gm/techtalk1.cpp ('k') | gyp/gmslides.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698